-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Hugging Interaction Popup From Humanoids #710
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimpleStation14
changed the title
remove hugging interaction popup from humanoids
Remove Hugging Interaction Popup From Humanoids
Aug 9, 2024
DangerRevolution
requested review from
VMSolidus,
DEATHB4DEFEAT,
Peptide90,
Pspritechologist,
OldDanceJacket,
DangerRevolution and
NotScoutieBoi
August 9, 2024 19:11
DangerRevolution
added
Priority: 5-Whenever
Doesn't matter when this gets resolved
Size: 5-Very Small
For especially small issues/PRs
Status: Needs Discussion
Must be discussed
Type: Cleanup
Like Rework but small
and removed
Status: Needs Review
Someone please review this
labels
Aug 9, 2024
DangerRevolution
approved these changes
Aug 10, 2024
VMSolidus
approved these changes
Aug 10, 2024
SimpleStation14
added a commit
that referenced
this pull request
Aug 10, 2024
Mnemotechnician
added a commit
to Mnemotechnician/Einstein-Engines
that referenced
this pull request
Aug 11, 2024
2 tasks
1 task
tmcqueen
pushed a commit
to tmcqueen/Syndicate-Station
that referenced
this pull request
Aug 24, 2024
<!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Description Reasoning: 1) Hugging your coworkers isn't necessarily always inappropriate, but it's something that should take a bit more intention than it does now. 2) Event subs in this game right now still have no good method of handling multiple subscriptions to the same event. The hugging event is occupying 2 pieces of prime real estate - the empty hand interaction, which is the most common, and the humanoid interaction, which is the most common and most important. And for what? Spamming popups and chat for something that could just be an emote. 3) Because of the above, it's too easy to accidentally hug people while doing something else - the lack of intersectionality makes people just ignore hugging because they assume it means nothing and was not intentional. This does not lead to good roleplay outcomes. 4) I left the petting stuff on animals because that's much more common and appropriate and you're less likely to be trying to do other complex interactions with them. Also, since they're usually NPCs, it doesn't matter if they get desensitized to the interaction as meaningless, or at least it's out of scope. # Changelog :cl: Rane - remove: Removed the spammable hugging on click. Consider using emotes for this instead.
tmcqueen
pushed a commit
to tmcqueen/Syndicate-Station
that referenced
this pull request
Aug 24, 2024
tmcqueen
pushed a commit
to tmcqueen/Syndicate-Station
that referenced
this pull request
Aug 24, 2024
<!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Description Reasoning: 1) Hugging your coworkers isn't necessarily always inappropriate, but it's something that should take a bit more intention than it does now. 2) Event subs in this game right now still have no good method of handling multiple subscriptions to the same event. The hugging event is occupying 2 pieces of prime real estate - the empty hand interaction, which is the most common, and the humanoid interaction, which is the most common and most important. And for what? Spamming popups and chat for something that could just be an emote. 3) Because of the above, it's too easy to accidentally hug people while doing something else - the lack of intersectionality makes people just ignore hugging because they assume it means nothing and was not intentional. This does not lead to good roleplay outcomes. 4) I left the petting stuff on animals because that's much more common and appropriate and you're less likely to be trying to do other complex interactions with them. Also, since they're usually NPCs, it doesn't matter if they get desensitized to the interaction as meaningless, or at least it's out of scope. # Changelog :cl: Rane - remove: Removed the spammable hugging on click. Consider using emotes for this instead.
tmcqueen
pushed a commit
to tmcqueen/Syndicate-Station
that referenced
this pull request
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes: Localization
Changes any ftl files
Changes: YML
Changes any yml files
Priority: 5-Whenever
Doesn't matter when this gets resolved
Size: 5-Very Small
For especially small issues/PRs
Status: Needs Discussion
Must be discussed
Type: Cleanup
Like Rework but small
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reasoning:
Changelog
🆑 Rane